Fix '?' in ReflectionNamedType::getName() from ReflectionProperty::getSettableType()

Author: iluuu1994

ext/reflection/php_reflection.c

@@ -6517,7 +6517,7 @@ ZEND_METHOD(ReflectionProperty, getSettableType)
 	/* Get-only virtual property can never be written to. */
 	if (prop->hooks && (prop->flags & ZEND_ACC_VIRTUAL) && !prop->hooks[ZEND_PROPERTY_HOOK_SET]) {
 		zend_type never_type = ZEND_TYPE_INIT_CODE(IS_NEVER, 0, 0);
-		reflection_type_factory(never_type, return_value, 0);
+		reflection_type_factory(never_type, return_value, 1);
 		return;
 	}
 
@@ -6527,15 +6527,15 @@ ZEND_METHOD(ReflectionProperty, getSettableType)
 		if (!ZEND_TYPE_IS_SET(arg_info->type)) {
 			RETURN_NULL();
 		}
-		reflection_type_factory(arg_info->type, return_value, 0);
+		reflection_type_factory(arg_info->type, return_value, 1);
 		return;
 	}
 
 	/* Fall back to property type */
 	if (!ZEND_TYPE_IS_SET(ref->prop->type)) {
 		RETURN_NULL();
 	}
-	reflection_type_factory(ref->prop->type, return_value, 0);
+	reflection_type_factory(ref->prop->type, return_value, 1);
 }
 
 /* {{{ Returns whether property has a type */

ext/reflection/tests/gh19187.phpt

@@ -0,0 +1,19 @@
+--TEST--
+GH-19187: ReflectionNamedType::getName() should not include nullable type
+--FILE--
+<?php
+
+class Foo {
+    public string|null $bar {
+        set(string|null $value) => $value;
+    }
+}
+
+$reflProp = new ReflectionProperty(Foo::class, 'bar');
+echo $reflProp->getType()->getName(), "\n";
+echo $reflProp->getSettableType()->getName(), "\n";
+
+?>
+--EXPECT--
+string
+string