Promote warning to exception in parse_url()

Author: kocsismate

ext/standard/tests/url/parse_url_error_002.phpt

@@ -14,8 +14,12 @@ $url = 'http://secret:[email protected]:80/index.php?test=1&test2=char&test3=m
 echo "--> Below range:";
 var_dump(parse_url($url, -1));
 
-echo "\n\n--> Above range:";
-var_dump(parse_url($url, 99));
+echo "\n\n--> Above range:\n";
+try {
+    parse_url($url, 99);
+} catch (ValueError $exception) {
+    echo $exception->getMessage() . "\n";
+}
 
 echo "Done"
 ?>
@@ -42,6 +46,5 @@ echo "Done"
 
 
 --> Above range:
-Warning: parse_url(): Invalid URL component identifier 99 in %s on line 15
-bool(false)
+Invalid URL component identifier: 99
 Done

ext/standard/url.c

@@ -363,8 +363,8 @@ PHP_FUNCTION(parse_url)
 				if (resource->fragment != NULL) RETVAL_STR_COPY(resource->fragment);
 				break;
 			default:
-				php_error_docref(NULL, E_WARNING, "Invalid URL component identifier " ZEND_LONG_FMT, key);
-				RETVAL_FALSE;
+				zend_value_error("Invalid URL component identifier: " ZEND_LONG_FMT, key);
+				break;
 		}
 		goto done;
 	}