Fix GH-18404: Always prompt to save test report

Author: alexandre-daubois

.circleci/config.yml

@@ -166,6 +166,7 @@ jobs:
           name: Test
           no_output_timeout: 30m
           command: |
+            export NO_INTERACTION=1
             sapi/cli/php run-tests.php \
               -d opcache.enable_cli=1 \
               -d opcache.jit_buffer_size=64M \

.github/actions/freebsd/action.yml

@@ -106,6 +106,7 @@ runs:
           export SKIP_IO_CAPTURE_TESTS=1
           export CI_NO_IPV6=1
           export STACK_LIMIT_DEFAULTS_CHECK=1
+          export NO_INTERACTION=1
           sapi/cli/php run-tests.php \
             -P -q -j2 \
             -g FAIL,BORK,LEAK,XLEAK \

.github/actions/test-alpine/action.yml

@@ -14,6 +14,7 @@ runs:
         set -x
         export SKIP_IO_CAPTURE_TESTS=1
         export STACK_LIMIT_DEFAULTS_CHECK=1
+        export NO_INTERACTION=1
         sapi/cli/php run-tests.php -P -q ${{ inputs.runTestsParameters }} \
           -d opcache.jit=${{ inputs.jitType }} \
           -d opcache.jit_buffer_size=64M \

.github/actions/test-gentoo/action.yml

@@ -25,6 +25,7 @@ runs:
         # Slow tests criteron is doubled because this runner isn't as fast as others
         export SKIP_IO_CAPTURE_TESTS=1
         export STACK_LIMIT_DEFAULTS_CHECK=1
+        export NO_INTERACTION=1
         sapi/cli/php run-tests.php -P -q ${{ inputs.runTestsParameters }} \
           -j$(nproc) \
           -g FAIL,BORK,LEAK,XLEAK \

.github/actions/test-libmysqlclient/action.yml

@@ -14,6 +14,7 @@ runs:
         export PDO_MYSQL_TEST_HOST=127.0.0.1
         export PDO_MYSQL_TEST_USER=root
         export PDO_MYSQL_TEST_PASS=root
+        export NO_INTERACTION=1
         sapi/cli/php run-tests.php -P -q \
           -g FAIL,BORK,LEAK,XLEAK \
           --no-progress --offline --show-diff --show-slow 1000 --set-timeout 120 \

.github/actions/test-linux/action.yml

@@ -41,6 +41,7 @@ runs:
         export PDO_ODBC_TEST_DSN="odbc:Driver={ODBC Driver 17 for SQL Server};Server=127.0.0.1;Database=pdo_odbc;uid=$ODBC_TEST_USER;pwd=$ODBC_TEST_PASS"
         export SKIP_IO_CAPTURE_TESTS=1
         export STACK_LIMIT_DEFAULTS_CHECK=1
+        export NO_INTERACTION=1
         sapi/cli/php run-tests.php -P -q ${{ inputs.runTestsParameters }} \
           -d opcache.jit=${{ inputs.jitType }} \
           -d opcache.protect_memory=1 \

.github/actions/test-macos/action.yml

@@ -15,6 +15,7 @@ runs:
         export SKIP_IO_CAPTURE_TESTS=1
         export CI_NO_IPV6=1
         export STACK_LIMIT_DEFAULTS_CHECK=1
+        export NO_INTERACTION=1
         sapi/cli/php run-tests.php -P -q ${{ inputs.runTestsParameters }} \
           -d opcache.jit=${{ inputs.jitType }} \
           -d opcache.protect_memory=1 \

run-tests.php

@@ -691,8 +691,10 @@ function main(): void
     verify_config($php);
     write_information($user_tests, $phpdbg);
 
+    $exts_tested = $exts_to_test;
+    $exts_skipped = [];
+
     if ($test_cnt) {
-        putenv('NO_INTERACTION=1');
         usort($test_files, "test_sort");
         $start_time = hrtime(true);
 
@@ -721,12 +723,12 @@ function main(): void
 
         if ($output_file != '' && $just_save_results) {
             save_results($output_file, /* prompt_to_save_results: */ false);
+        } else {
+            save_results($output_file, /* prompt_to_save_results: */ true);
         }
     } else {
         // Compile a list of all test files (*.phpt).
         $test_files = [];
-        $exts_tested = $exts_to_test;
-        $exts_skipped = [];
         sort($exts_to_test);
 
         foreach (['Zend', 'tests', 'ext', 'sapi'] as $dir) {