uri: Unify string creation in php_uri_parser_rfc3986_scheme_read()

TimWolla · TimWolla · commit f6c3e4664835 · 2025-08-25T20:34:14.000+02:00
diff --git a/ext/uri/uri_parser_rfc3986.c b/ext/uri/uri_parser_rfc3986.c
@@ -100,8 +100,7 @@ ZEND_ATTRIBUTE_NONNULL static zend_result php_uri_parser_rfc3986_scheme_read(con
 	ZEND_ASSERT(uriparser_uri != NULL);
 
 	if (uriparser_uri->scheme.first != NULL && uriparser_uri->scheme.afterLast != NULL) {
-		zend_string *str = zend_string_init(uriparser_uri->scheme.first, get_text_range_length(&uriparser_uri->scheme), false);
-		ZVAL_NEW_STR(retval, str);
+		ZVAL_STRINGL(retval, uriparser_uri->scheme.first, get_text_range_length(&uriparser_uri->scheme));
 	} else {
 		ZVAL_NULL(retval);
 	}

Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,7 @@ ZEND_ATTRIBUTE_NONNULL static zend_result php_uri_parser_rfc3986_scheme_read(con`
`100`	`100`	`ZEND_ASSERT(uriparser_uri != NULL);`
`101`	`101`
`102`	`102`	`if (uriparser_uri->scheme.first != NULL && uriparser_uri->scheme.afterLast != NULL) {`
`103`		`- zend_string *str = zend_string_init(uriparser_uri->scheme.first, get_text_range_length(&uriparser_uri->scheme), false);`
`104`		`- ZVAL_NEW_STR(retval, str);`
	`103`	`+ ZVAL_STRINGL(retval, uriparser_uri->scheme.first, get_text_range_length(&uriparser_uri->scheme));`
`105`	`104`	`} else {`
`106`	`105`	`ZVAL_NULL(retval);`
`107`	`106`	`}`