Skip to content

Commit fd3f247

Browse files
shqkingdstogov
authored andcommitted
Revert the macro uses for Z_TYPE_P(val) in commit 1fff62b
As suggested by Dmitry, macro CMP_32_WITH_CONST is not necessary because Z_TYPE_P(val) is of uchar type and it can be encoded as the imm field of 'cmp' instruction directly. Change-Id: Icb8f9ee847b9a08cb1e9127e7faf6c89d1431922
1 parent 59622d9 commit fd3f247

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ext/opcache/jit/zend_jit_arm64.dasc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7518,7 +7518,7 @@ static int zend_jit_identical(dasm_State **Dst,
75187518
zval *val = Z_ZV(op1_addr);
75197519

75207520
| ldrb TMP1w, [FCARG2x, #offsetof(zval, u1.v.type)]
7521-
| CMP_32_WITH_CONST TMP1w, Z_TYPE_P(val), TMP2w
7521+
| cmp TMP1w, #Z_TYPE_P(val)
75227522
if (smart_branch_opcode) {
75237523
if (opline->op2_type == IS_VAR && (op2_info & MAY_BE_REF)) {
75247524
| bne >8
@@ -7570,7 +7570,7 @@ static int zend_jit_identical(dasm_State **Dst,
75707570
zval *val = Z_ZV(op2_addr);
75717571

75727572
| ldrb TMP1w, [FCARG1x, #offsetof(zval, u1.v.type)]
7573-
| CMP_32_WITH_CONST TMP1w, Z_TYPE_P(val), TMP2w
7573+
| cmp TMP1w, #Z_TYPE_P(val)
75747574
if (smart_branch_opcode) {
75757575
if (opline->opcode != ZEND_CASE_STRICT
75767576
&& opline->op1_type == IS_VAR && (op1_info & MAY_BE_REF)) {

0 commit comments

Comments
 (0)