Fix GH-13391: Drop unsupported libxml2 2.10.0 symbols #13392
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docbook parser module has been removed completely. Support for XPointer locations (ranges and points) is disabled by default, and will eventually be removed completely. Given that the maintainer comments on the latter: "Be warned that this part of the code base is buggy and had many security issues in the past", it seems to be prudent to no longer build with XPointer locations support right away. To be able to build against libxml2 2.10.0 and later, we remove the export definitions for Windows. Closes phpGH-13391. (cherry picked from commit ca011bb)
|
Closing as per #13391 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docbook parser module has been removed completely. Support for XPointer locations (ranges and points) is disabled by default, and will eventually be removed completely. Given that the maintainer comments on the latter: "Be warned that this part of the code base is buggy and had many security issues in the past", it seems to be prudent to no longer build with XPointer locations support right away.
To be able to build against libxml2 2.10.0 and later, we remove the export definitions for Windows.
Closes GH-13391.
(cherry picked from commit ca011bb)