Skip to content

Conversation

@iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented May 14, 2024

@dstogov I'm planning on using making a bunch of such suggestions, if you think they are ok. The goal is to minimize changes in optimizer when adding new opcodes, because:

  1. It's tedious.
  2. Most contributors shouldn't need to understand the optmizer, and minimizing the necessary changes will simplify things for them.

Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the proposed code is going to be slower.
Instead, it may make sense to add assertions into default path.
This way we will be sure that nothing is missed.

@iluuu1994
Copy link
Member Author

I had hoped to generate pre-processor macros for such paths by zend_vm_gen.php. I'll create a new PR if I ever want to do that.

@iluuu1994 iluuu1994 closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants