Php 8.4 - ReflectionProperty->getHooks() on dynamic property results in segmentation fault

[bkdotcom]

Description

The following code:

https://3v4l.org/nurSR/rfc#vgitmaster

<?php

#[\AllowDynamicProperties]
class SegFault
{
}

$segFault = new SegFault();
$segFault->dynamicProp = 'dont call getHooks!';

$reflectionProperty = new ReflectionProperty($segFault, 'dynamicProp');

$reflectionProperty->getHooks();

Resulted in this output:

Segmentation fault: 11

But I expected this output instead:

¯\_(ツ)_/¯
getHooks should return an empty array
perhaps throw an exception on a dynamic property
definitely not segFault

PHP Version

PHP 8.4 2024-09-03

Operating System

osx & 3v4l.org

[nielsdos]

Intuitively, I suspect that ref->prop is NULL, which also means that getHook has the same problem.
But I'm on mobile rn and can't check.

[DanielEScherzer]

Its not just with #[\AllowDynamicProperties], but also when using stdClass, or even classes that don't allow dynamic and thus issue a warning while still being used.

Its also not just getHooks(), but also getHook(), with this issue

[DanielEScherzer]

PR at #15721, I don't seem to have the rights to link it as closing this issue

[iluuu1994]

Thanks @bkdotcom and @DanielEScherzer!

[bkdotcom]

Early adoption for the win!