Skip to content

Conversation

zeriyoshi
Copy link
Contributor

These tests will always fail when run-tests.php is executed with -d opcache.enable=0 . Add opcache.enable=1 to the INI section to ensure it's always overridden.

@zeriyoshi
Copy link
Contributor Author

This can be resolved by not loading the OPcache Zend Extension in the first place. However, in this case, the normal make test can't be used, and you'll need to manually run run-tests.php. (This is what the php-src CI does)

That said, because opcache is in the EXTENSIONS directive, this test will fail with opcache.enable=0. I can't judge whether this needs to be fixed or not.

Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right.

../ext/opcache/tests/gh9164.phpt also needs to be fixed.
This needs to be targeted to PHP-8.2.

I'll take care...

@dstogov
Copy link
Member

dstogov commented Sep 9, 2024

Merged via bca5f6e and d966c29

@dstogov dstogov closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants