error formatting inconsistency regarding spaces

[staabm]

Description

running automated tests in private repo, I recently noticed that some error messages contain more spaces then other
(macos vs. ubuntu github action)

The following code:

<?php

function subtract_no_lint($m { // intentional syntax error
}

Resulted in this output: (note 2 spaces after Parse error:)

Parse error:  syntax error, unexpected token "{", expecting ")" in does-not-lint.php on line 3

But I expected this output instead: (note 1 space after Parse error:)

Parse error: syntax error, unexpected token "{", expecting ")" in does-not-lint.php on line 3

I saw similar differences in the php-src testsuite, see e.g.

PHP Version

8.3.11

Operating System

ubuntu / macos

[cmb69]

There are multiple such issues in https://github.com/php/php-src/blob/master/main/main.c, and maybe more in other files. I wouldn't call that a bug, though, but improving the error messages might be a good idea for PHP 8.4.

[DanielEScherzer]

Resulted in this output: (note 2 spaces after Parse error:)

https://3v4l.org/7Thc1 suggests that it has consistently been a single space, including on 8.3.11?

But the cgi test given in the description does use 2 spaces -

php-src/sapi/cgi/tests/012.phpt

Line 83 in 42e179e

[2] => <b>Parse error</b>: syntax error, unexpected token &quot;private&quot;, expecting &quot;{&quot; in <b>%s012_bad.test.php</b> on line <b>5</b><br />

The extra spacing seems to come from the HTML formatting out the output, rather than the messages -

php-src/main/main.c

Line 1405 in 42e179e

php_printf("%s<br />\n<b>%s</b>: %s in <b>%s</b> on line <b>%" PRIu32 "</b><br />\n%s", STR_PRINT(prepend_string), error_type_str, ZSTR_VAL(buf), ZSTR_VAL(error_filename), error_lineno, STR_PRINT(append_string));

[cmb69]

The extra spacing seems to come from the HTML formatting out the output, rather than the messages -

That is one occassion. There are also

php-src/main/main.c

Line 1390 in 4704f00

spprintf(&log_buffer, 0, "PHP %s: %s in %s on line %" PRIu32, error_type_str, ZSTR_VAL(message), ZSTR_VAL(error_filename), error_lineno);

php-src/main/main.c

Line 1708 in 4704f00

snprintf(memory_leak_buf, 512, "%s(%" PRIu32 ") : Freeing " ZEND_ADDR_FMT " (%zu bytes), script=%s\n", t->filename, t->lineno, (size_t)t->addr, t->size, SAFE_FILENAME(SG(request_info).path_translated));

php-src/main/main.c

Line 2255 in 4704f00

fprintf(stderr, "PHP: Unable to initialize stream url wrappers.\n");

and maybe even more.