JIT for INIT_STATIC_METHOD_CALL #16206
Conversation
|
This PR brings around 0.88% perf improvement for Laravel. The rest of the tests are very similar as before. |
ext/opcache/jit/zend_jit_helpers.c
Outdated
| return fbc; | ||
| } | ||
|
|
||
| static zend_execute_data* ZEND_FASTCALL zend_jit_push_this_metod_call_frame(zend_class_entry *scope, zend_function *fbc, uint32_t num_args) |
ext/opcache/jit/zend_jit_ir.c
Outdated
|
|
||
| ZEND_ASSERT(Z_TYPE_P(zv) == IS_STRING); | ||
| class_name = Z_STR_P(zv); | ||
| ce = zend_lookup_class_ex(class_name, NULL, ZEND_FETCH_CLASS_NO_AUTOLOAD); |
There was a problem hiding this comment.
Would it be beneficial to use the runtime cache to save some compilation time? In the tracing JIT the cache is probably primed. We could also use it as profiling data in some cases.
There was a problem hiding this comment.
This may be a good idea, but I would prefer to land this patch as is and than think about data-profiling improvement.
There was a problem hiding this comment.
Of course! This was just a thought I had while looking the change, but I agree it's not within the scope of this PR
ext/opcache/jit/zend_jit_ir.c
Outdated
| if (op_array->fn_flags & ZEND_ACC_STATIC) { | ||
| scope_ref = ir_LOAD_A(jit_EX(This.value.ref)); | ||
| } else { | ||
| scope_ref = ir_LOAD_A(ir_ADD_OFFSET(jit_EX(This.value.ref), offsetof(zend_object, ce))); |
There was a problem hiding this comment.
| scope_ref = ir_LOAD_A(ir_ADD_OFFSET(jit_EX(This.value.ref), offsetof(zend_object, ce))); | |
| scope_ref = ir_LOAD_A(ir_ADD_OFFSET(ir_LOAD_A(jit_EX(This.value.ref)), offsetof(zend_object, ce))); |
ext/opcache/jit/zend_jit_ir.c
Outdated
| } | ||
| } | ||
|
|
||
| if (opline->op1_type == IS_CONST) { |
There was a problem hiding this comment.
This check with the "then" and "else" branch are almost identically the same to what happens in zend_jit_fetch_static_prop, except for the op number. Perhaps this can be factored out to a separate method?
4 participants
No description provided.