Skip to content

Fix GH-16257 imagescale underflow on RGB channels. #16274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix GH-16257 imagescale underflow on RGB channels. #16274

wants to merge 2 commits into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Oct 6, 2024

backport of libgd/libgd@948bb0a

@devnexen devnexen marked this pull request as draft October 6, 2024 21:00
@devnexen devnexen marked this pull request as ready for review October 7, 2024 06:49
@devnexen devnexen requested a review from cmb69 October 7, 2024 06:50
cmb69
cmb69 reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks basically good to me, but the indentation seems to mix spaces and tabs. Since most of this file in our bundled libgd uses tabs, I suggest to also use tabs here.

cmb69
cmb69 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@devnexen
Copy link
Member Author

devnexen commented Nov 2, 2024

Merged with a2bdfef

@devnexen devnexen closed this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees

No one assigned

Labels

Extension: gd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devnexen @cmb69