Fix zend_max_execution_timer.h cannot be included by the C++ extension.

[matyhtf]

In the Swoole extension, including zend_max_execution_timer.h and calling the zend_max_execution_timer_init function leads to an undefined symbol error. This function should be exported in C symbol format.

php: symbol lookup error: swoole.so: undefined symbol: _Z29zend_max_execution_timer_initv

[arnaud-lb]

Please move the #include outside of the BEGIN_EXTERN_C() block

[matyhtf]

done

[matyhtf]

The solution to avoid modifying this file is to add extern "C" around #include php.ini.

#ifdef __cplusplus
extern "C" {
#endif

#include "php.h"

#ifdef __cplusplus
}
#endif

[matyhtf]

ad85e71

It is advisable not to add new header files in the release version. The file zend_max_execution_timer.h was added in PHP version 8.1.18RC1, whereas the PHP version in the Ubuntu 22.04 apt repository is 8.1.3. Consequently, using the zend_max_execution_timer API will result in a compilation failure on Ubuntu systems.

@dunglas

[dunglas]

@matyhtf Yes we know that but this is both a bug fix and a feature. Without this new system, timeouts are totally broken in multithreaded programs and there is nothing else we can do to fix that. This feature is off by default for PHP 8.1 if not compiled in ZTS mode, so the ABI didn't change for most users.

[dunglas]

Only this function must be called in extensions if they fork(). It nay not be necessary to protect the two other definitions.

[matyhtf]

OK, updated.

[arnaud-lb]

Thank you @matyhtf!