Deprecate mhash constants #16569
Closed
Deprecate mhash constants #16569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mhash functions already have been deprecated as of PHP 8.1.0[1], but the respective constants appear to have been missed. We catch up on that. [1] <https://wiki.php.net/rfc/deprecations_php_8_1#mhash_function_family>
|
should/will stubs also reflect the deprecation? |
There are no stubs, and I don't think we'll introduce any. See also php/doc-en#3902. |
|
Possibly add this to: https://wiki.php.net/rfc/deprecations_php_8_5 ? |
|
What happens if it gets declined? Do we remove the functions, but keep the constants? ;) On the other hand, they're still useful even without the functions: I'll write to internals. |
kamil-tekiela
approved these changes
Oct 25, 2024
TimWolla
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mhash functions already have been deprecated as of PHP 8.1.0[1], but the respective constants appear to have been missed. We catch up on that.
[1] https://wiki.php.net/rfc/deprecations_php_8_1#mhash_function_family