Add UnitEnum::$name and BackedEnum::$value properties

[vudaltsov]

Description

The following code:

<?php

var_dump(new ReflectionClass(UnitEnum::class)->getProperties());
var_dump(new ReflectionClass(BackedEnum::class)->getProperties());

Resulted in this output:

array(0) {
}
array(0) {
}

Wouldn't it make sense to model enum's properties as interface properties in PHP 8.4?

PHP Version

PHP 8.4.0-dev (cli) (built: Oct 23 2024 11:58:07) (NTS)

Operating System

MacOS

[phpcodingmaster]

Hi @vudaltsov, why would you want to model enum properties as interface properties?

[SakiTakamachi]

At least this is not acceptable in 8.4. The release cycle is already past the stage to accommodate such feature changes.

If we accept this, will need to target 8.5/9.0, but first need to discuss this on our internal mailing list. This requires an RFC.

[vudaltsov]

Hi @vudaltsov, why would you want to model enum properties as interface properties?

Because they are properties, you can write code like this (https://3v4l.org/DWhEM):

enum A
{
    case X;
}

function dumpEnumName(\UnitEnum $enum): void
{
    var_export($enum->name);
}

var_dump(dumpEnumName(A::X));

This is autocompleted in PhpStorm:

Also see PhpStorm stubs: https://github.com/JetBrains/phpstorm-stubs/blob/893a3bc59b8ff1b995220abcbbf76796926b7e9a/Core/Core_c.php#L919.

This requires an RFC.

@SakiTakamachi, yes, I agree that this is a feature, not a bug. I will make an RFC later.

[TimWolla]

This requires an RFC.

I'm not sure this requires an RFC. It seems like an obvious addition to me: The interface cannot be manually implemented, so there is no breaking change. I agree though that this will need to wait for PHP 8.5.

[iluuu1994]

It's worth noting that we might need another interface for $name, because ADTs will not implement either UnitEnum nor BackedEnum. I'm guessing we didn't reserve Enum for backwards compatibility concerns, but I don't specifically remember.

[github-actions]

There has not been any recent activity in this feature request. It will automatically be closed in 14 days if no further action is taken. Please see https://github.com/probot/stale#is-closing-stale-issues-really-a-good-idea to understand why we auto-close stale feature requests.