Backport JIT fix: set valid EX(opline) before calling gc_possible_root() #16858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstogov
added a commit
that referenced
this pull request
Nov 19, 2024
* PHP-8.2: Backport JIT fix: set valid EX(opline) before calling gc_possible_root() (#16858)
dstogov
added a commit
that referenced
this pull request
Nov 19, 2024
* PHP-8.3: Backport JIT fix: set valid EX(opline) before calling gc_possible_root() (#16858)
dstogov
added a commit
that referenced
this pull request
Nov 19, 2024
* PHP-8.4: Backport JIT fix: set valid EX(opline) before calling gc_possible_root() (#16858)
|
@php/release-managers-81 Would you be ok with backporting this change to 8.1? It causes the community build in nightly to fail, and I don't see a way to ignore this error without disabling the entire Symfony package. That wouldn't be the end of the world, but the patch looks very low risk. |
I don't object. |
|
I approve of backporting this to 8.1. Let’s make CI green! |
iluuu1994
pushed a commit
to iluuu1994/php-src
that referenced
this pull request
Dec 9, 2024
iluuu1994
pushed a commit
that referenced
this pull request
Dec 9, 2024
…t() (#16858) This will finally make the COMMUNTIY build of the PHP 8.1 build green. See #16858 (comment) Closes GH-17091
iluuu1994
added a commit
that referenced
this pull request
Dec 9, 2024
* PHP-8.1: Backport JIT fix: set valid EX(opline) before calling gc_possible_root() (#16858)
iluuu1994
added a commit
that referenced
this pull request
Dec 9, 2024
* PHP-8.2: Backport JIT fix: set valid EX(opline) before calling gc_possible_root() (#16858)
iluuu1994
added a commit
that referenced
this pull request
Dec 9, 2024
* PHP-8.3: Backport JIT fix: set valid EX(opline) before calling gc_possible_root() (#16858)
iluuu1994
added a commit
that referenced
this pull request
Dec 9, 2024
* PHP-8.4: Backport JIT fix: set valid EX(opline) before calling gc_possible_root() (#16858)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.