integer overflow in tm2unixtime.c:209:4

[chongwick]

Description

The following code:

<?php
$max_int = PHP_INT_MAX;
$datetime = mktime(0, 0, 0, 1, $max_int, 1970);

Resulted in this output:

/home/dan/php-src/ext/date/lib/tm2unixtime.c:209:4: runtime error: signed integer overflow: 9223372036854775807 + 719467 cannot be represented in type 'long long int'

But I expected this output instead:

PHP Version

8.4.2

Operating System

ubuntu 22.04

[devnexen]

I think this fix may be needed for 8.4 branch ? cc @nielsdos

[chongwick]

These all seem fixed in 8.5. Just not 8.4

[ndossche]

We fixed these on master indeed, I recommend fuzzing that instead.
This one is also just a duplicate.
@devnexen I'm not sure if backporting is worth the risk-benefit trade-off.