set_exception_handler() should be named set_throwable_handler()

[adazmy]

Description

Both Error and Exception are handled by set_exception_handler() where the naming imply only the Exception.

A better explicit and intuitive name is set_throwable_handler().

I was not expecting the handler to be triggered by an Error and cancelling the default PHP behavior.

PS: not talking about E_XXX errors, but Error that implements Throwable

The following code:

<?php
function handler(){
     echo "Exception Handler";
}
set_exception_handler('handler');

new MyClass();

Resulted in this output:

Exception Handler

But I expected this output instead:

Fatal error: Uncaught Error: Class "MyClass" not found in /home/user/scripts/code.php:7
Stack trace:
#0 {main}
  thrown in /home/user/scripts/code.php on line 7

PHP Version

8.*

Operating System

No response

[cmb69]

In my opinion, a lot of BC break for a small gain. Anyhow, this requires the RFC process. Feel free to pursue it. :)

[iluuu1994]

I agree that this is a big BC break. The name is historic, the Error class was only introduced in PHP 7.0. Please consult the mailing list (step 1 of the RFC process) to see how this change is perceived by the community, but my suspicion is resistance (as here).

[adazmy]

I understand, and things are evolving in a good way and new code should not be based on legacy one.

A good alternative can be to have a function alias and mark the old one as deprecated without switching.

[iluuu1994]

@adazmy Yes, this would be possible. However, it seems at least 2 maintainers (me and Christoph) don't think it's necessary. That said, PHP is a community driven project and anybody can create an RFC, which you are free and encouraged to do. But keeping this issue open doesn't make much sense when the maintainers don't want to pursue it. 🙂

[cmb69]

I suggest writing to the internals mailing list. The discussion will go as follows:

I suggest to introduce set_throwable_handler() and make set_exception_handler() an alias.

But the new function should conform to newer naming conventions, i.e. it should be called throwable_set_handler().

We should have a static method on Throwable instead: Throwable::set_handler().

That is not possible, since Throwable is an interface.

Then we should introduce a class ThrowableIImp.

No, please, we should not follow that naming convention. It should be called StandardThrowable.

Okay, so StandardThrowable::set_handler() be it.

Nope, should not use snake case, since it's a method: StandardThrowable::setHandler().

Why would we introduce a new class; a function is perfectly fine. But it should be in a proper namespace: Throwable\set_handler().

It is confusing to have a Throwable interface and a Throwable namespace.

Okay, so go with set_throwable_handler().

But the new function should conform to newer naming conventions, i.e. it should be called throwable_set_handler().

… on and on, ad nauseam.