Fix NULL arithmetic during system program execution #17470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, so no NULL access, but NULL arithmetic (which indeed is UB). |
For the first child process execution, `TWG(process)` is `NULL`; we need to catch that to avoid undefined behavior.
cmb69
force-pushed
the
cmb/process_get-null
branch
from
08fcb6d to
2d2150c
Compare
cmb69
changed the title
Makes sense. Thank you! Done. |
ndossche
approved these changes
Jan 15, 2025
charmitro
pushed a commit
to wasix-org/php
that referenced
this pull request
Mar 13, 2025
For the first child process execution, `TWG(process)` is `NULL`; we need to catch that to avoid undefined behavior. Closes phpGH-17470.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the first child process execution,
TWG(process)isNULL; we need to catch that to avoid undefined behavior.