Zend: Remove zend_fcall_info_args_ex() #17652
Open
+8
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last usage within php-src was within PDO but this is no longer the case since 3ff7758 Moreover, external usage is very limited and the two usages I could find have been removed. [1][2] [1] zephir-lang/zephir@82a8d05 [2] krakjoe/uopz@b1015ae
Girgias
force-pushed
the
fci-api-removal
branch
from
174ec4d to
c5ac76a
Compare
dstogov
reviewed
Feb 3, 2025
|
Maybe deprecate in 8.5 and remove in 8.6? |
TimWolla
reviewed
Oct 12, 2025
Comment on lines
+22
to
+27
| . The zend_fcall_info_args_ex() API has been removed. | ||
| This is because it does not follow the usual CUFA semantics and it | ||
| automatically wraps by-value arguments into references for by-ref | ||
| parameters. | ||
| It is recommended to set the FCI named_params instead, | ||
| however zend_fcall_info_args() can also be used. |
There was a problem hiding this comment.
I'd like to see a little more actionable description of what to do when previously passing a non-NULL func for some reason.
There was a problem hiding this comment.
There is none, because the semantics exposed are non-standard and cannot be mimicked in userland. It effectively does the same as the @prefer-ref $array annotation we have in core that allows to pass values to by-reference arguments. Something that I've been told we should not expand on, as that was the main pushback against https://wiki.php.net/rfc/array-sort-return-array
This is basically not a C developer issue, but a PHP userland one where the end-user doesn't pass a variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last usage within php-src was within PDO but this is no longer the case since 3ff7758 Moreover, external usage is very limited and the two usages I could find have been removed. [1][2]
[1] zephir-lang/zephir@82a8d05
[2] krakjoe/uopz@b1015ae