ext/pdo: Pack _pdo_dbh_t struct #17741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
commented
Feb 8, 2025
ext/pdo/php_pdo_driver.h
Outdated
| * equal 32 */ | ||
| unsigned _reserved_flags:14; | ||
| /* bitmap for pdo_param_event(s) to skip in dispatch_param_event */ | ||
| uint8_t skip_param_evt; |
There was a problem hiding this comment.
Annoyingly, being able to specify the size of a C enum is a C23 feature, otherwise we could just use pdo_param_event here.
Girgias
force-pushed
the
pdo-dbh_struct-pack
branch
from
beffcfc to
8fb42f4
Compare
nielsdos
reviewed
Feb 8, 2025
Girgias
force-pushed
the
pdo-dbh_struct-pack
branch
from
8fb42f4 to
2a649c3
Compare
nielsdos
requested changes
Feb 10, 2025
ext/pdo/php_pdo_driver.h
Outdated
| unsigned int refcount; | ||
|
|
||
| uint32_t refcount; | ||
| uint32_t __reserved_padding; |
There was a problem hiding this comment.
Don't do this. Also: never use names starting with underscores as they're generally reserved.
There was a problem hiding this comment.
FWIW: with "don't do this" I meant adding explicit padding fields
There was a problem hiding this comment.
Yes I understood this, just forgot to get round to this again :)
This reduces the size from 176 to 152 bytes
Girgias
force-pushed
the
pdo-dbh_struct-pack
branch
from
2a649c3 to
cd4f2df
Compare
nielsdos
approved these changes
Mar 4, 2025
|
C23 would come in handy here with being able to specify the backing type of the enum |
stancl
added a commit
to stancl/msphpsql
that referenced
this pull request
Oct 19, 2025
Since php/php-src#17741, dbh->error_mode is stored as uint8_t. We cast the value to pdo_error_mode for the assignment to work. Since php/php-src#17742, query_stmt_zval has been replaced by query_stmt_obj. The diff in the linked PR shows the new destructor usage. We follow that same usage in this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size from 176 to 152 bytes