Skip to content

Conversation

@alexander-schranz
Copy link

@alexander-schranz alexander-schranz commented Feb 17, 2025

Not sure if maybe only exclude /.github, /.circleci files.
As I think when download from https://www.php.net/downloads.php it should not be included.

I quickly added:

/.circleci export-ignore
/.github export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore
/.editorconfig export-ignore
/codecov.yml export-ignore
/benchmark export-ignore
/CODING_STANDARDS.md export-ignore
/CONTRIBUTING.md export-ignore
/docs export-ignore
/docs-old export-ignore
/README.md export-ignore

@cmb69
Copy link
Member

cmb69 commented Feb 17, 2025

Thank you! Makes generally sense to me (I'm often annoyed when downloading tarballs of other packages and having all those "useless" files). Which files/directories to exclude might indeed be arguable, though.

Maybe @php/release-managers have an opinion about this.

@iluuu1994
Copy link
Member

Will this change actually be effective though? I'm not too familiar with the release process, but FWIU this would need support from scripts/dev/makedist itself.

@NattyNarwhal
Copy link
Member

Wouldn't this only affect the GitHub generated tarballs? For actual release tags, we'd want to use the proper release tarball.

@TimWolla
Copy link
Member

but FWIU this would need support from scripts/dev/makedist itself.

makedist uses git archive, which automatically interprets .gitattributes, so this would just work.

@iluuu1994
Copy link
Member

Ahh, I see. For some reason, I thought this was modifying a GH specific file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants