Skip to content

Fix opcode length of ZEND_DECLARE_ATTRIBUTED_CONST in JIT-IR component #18457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Fix opcode length of ZEND_DECLARE_ATTRIBUTED_CONST in JIT-IR component #18457

merged 1 commit into from
Apr 30, 2025

Conversation

@nielsdos
Copy link
Member

Introduced in 3f03f7e.

@nielsdos nielsdos requested a review from dstogov as a code owner April 29, 2025 19:37
DanielEScherzer
DanielEScherzer approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that we can introduce that would have caught this?

@nielsdos
Copy link
Member Author

Is there a test that we can introduce that would have caught this?

I didn't think of a test, it should be possible to make one using the minimal JIT.

@nielsdos nielsdos merged commit 39a56a1 into php:master Apr 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstogov dstogov dstogov approved these changes

@DanielEScherzer DanielEScherzer DanielEScherzer approved these changes

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

Assignees

No one assigned

Labels

Extension: opcache

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nielsdos @dstogov @DanielEScherzer