ext/date: various optimizations of _php_gettimeofday #18560
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgsowa
changed the title
devnexen
approved these changes
May 15, 2025
derickr
reviewed
May 26, 2025
| $get_as_float = false; | ||
|
|
||
| // Calling gettimeofday() with all possible arguments | ||
| var_dump( gettimeofday($get_as_float) ); |
There was a problem hiding this comment.
Please don't change test cases at the same time as actual code changes.
There was a problem hiding this comment.
I don't change the test case. It's only removal of unnecessary variables and comments. There is no functional change.
| offset = timelib_get_time_zone_info(tp.tv_sec, get_timezone_info()); | ||
|
|
||
| array_init(return_value); | ||
| array_init_size(return_value, 4); |
There was a problem hiding this comment.
Does this really improve things a lot?
There was a problem hiding this comment.
It's the same change as in recent PR #18382
Not much, but still something.
|
May this PR be merged? |
|
If I may, I would suggest to revert the test changes (can be argued and done in a separate PR). |
|
It makes completely no sense. Anyways, it's not important PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-allocated size of array for
_php_gettimeofdayand improved typing.