Fix GH-18634: Show warning when saving session if a pipe character is used in one of the $_SESSION keys #18653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
May 25, 2025
I can apply this change to master and submit a PR for that if that's OK? |
|
I changed the base branch of the PR to master, can you rebase the PR on top of master and force push? Otherwise, the PR looks goods to me. :) |
…e key Changes based on feedback. Updated error message, added explicit test for session_write_close() and tidied up tests.
Girgias
approved these changes
May 25, 2025
|
Thanks everyone for all the help and advice on my first contribution to PHP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning that is raised on session write if one of the session key variables contains the pipe character - as this will cause the session data to not be saved. Tests are included to cover this in both request shutdown and explicitly session_write_close().