Skip to content

Conversation

@SakiTakamachi
Copy link
Member

PHP and Zend code (especially macros) that were scattered throughout libbcmath have been consolidated into adapter.h and replaced with names like BC_XXX. This makes it easier to identify external dependencies.

@SakiTakamachi SakiTakamachi force-pushed the bcmath/organize_dependencies branch from 06db32a to 85abb65 Compare June 5, 2025 14:48
@SakiTakamachi SakiTakamachi marked this pull request as ready for review June 5, 2025 15:33
@nielsdos
Copy link
Member

nielsdos commented Jun 5, 2025

I don't think this makes sense.
It makes sense for bundled libs like timelib because they have a separate upstream thta can't integratie Zend or PHP specific bits in them.
For libbcmath, which has been bundled and adapted since ages already, this has no benefit.

@SakiTakamachi
Copy link
Member Author

@nielsdos

Hmm, that’s a very good point…
At this point, so little of the original remains that it might be quicker to count what is original, and honestly, I was hesitant about whether the change was worth making.

Thank you. I’ll go ahead and close this.

@SakiTakamachi SakiTakamachi deleted the bcmath/organize_dependencies branch June 5, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants