ext/calendar: jewishtojd overflow on year argument.

[devnexen]

Upper limit set to the 7th millenium (Messianic Age) in the jewish calendar,
around 2239 year in the gregorian calendar.

[devnexen]

upper limit can be changed (up to INT_MAX - 1), in practice I do not think there is a need to go too far in the future.

[SakiTakamachi]

Since zend_long is being cast to int, there’s a possibility of overflow during the downcast as well...

[kingIZZZY]

🙋‍♂️ Can I kindly oppose this change?

This change would be similar to imposing a 215 year limit on PHP DateTime, is there a known and agreed upon 215 year limit on lifetime of PHP usage?

The Jewish calendar does not end at year 6000, the Messianic Age does not state that time ends at year 6000.

I'm not too worried because given the previous 3500+ years of history, if this limitation is not reverted now, someone else will be there requesting this arbitrary limit to be removed in 215 years from now. That, or PHP might already be extinct.

Looking forward continuing using PHP's jewish calendar functionality way past year 6000 - PHP will be 300 years old in year 6055 😁

[devnexen]

I'm not too worried because given the previous 3500+ years of history, if this limitation is not reverted now, someone else will be there requesting this arbitrary limit to be removed in 215 years from now. That, or PHP might already be extinct.

exactly, you and I won't be here to see it anyway no need to lose sleep over it ;)

[kingIZZZY]

What I am losing sleep over is

1. What bug or problem prompted this change to begin with? Is there a short summary description or bug report that answers this
2. The very Messianic Age you mention specifically involves everlasting life 😁 (see current scientific studies in the areas of anti-aging medical/technological research & advancements)

you and I won't be here to see it anyway

Not so fast there :)

[devnexen]

all jokes aside, here the bug in question.
As for the limit, it is not written in stone we can always update it but to which degree, is the question.

[kingIZZZY]

Fair enough I guess

I do like the eschatological code decision 😁 big fan of the Messianic Age making its way into PHP source 👍