Skip to content

Support range of INT64_MIN/MAX on 32bit for DateTime[Immutable]::createFromTimestamp #18857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support range of INT64_MIN/MAX on 32bit for DateTime[Immutable]::createFromTimestamp #18857

wants to merge 1 commit into from

Conversation

marc-mabe
Copy link
Contributor

Timelib internally uses timelib_sll to store the unix timestamp which is int64_t.

This PR allows a range of INT64_MIN to INT64_MAX.999999 on 32 bit environments as well if initialized by createFromTimestamp(float).

@marc-mabe marc-mabe requested a review from derickr as a code owner June 16, 2025 11:41
@marc-mabe
Copy link
Contributor Author

@derickr ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derickr derickr Awaiting requested review from derickr derickr is a code owner

Assignees

No one assigned

Labels

ABI break Extension: date

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@marc-mabe