Fix GH-18877: \Dom\HTMLDocument querySelectorAll selecting only the first when using ~ and :has

[nielsdos]

Backports lexbor/lexbor@971faf1

cc @momala454
I'm a bit "scared" to backport such large patches, so perhaps this should land on master first and then be backported to 8.4 when no problems show up...

[Girgias]

Definitely fine for master, and it's probably fine for 8.4 as well I'd imagine, or is there a way to compile ext/dom by using an external lexbor version?

[nielsdos]

or is there a way to compile ext/dom by using an external lexbor version?

Fortunately not, as that would mean that I have to support even more configurations :P

[Girgias]

ACK, then it probably makes sense to backport.
Not exactly sure what our policy is for fixes in bundled libraries however :/

[nielsdos]

Not exactly sure what our policy is for fixes in bundled libraries however :/

I haven't heard of a policy regarding this. All I can say is that I've backported fixes to both ext/fileinfo and ext/pcre 🤷

[TimWolla]

Even upgrading to new upstream releases with a reasonable release policy (e.g. just fixes and good test coverage) within a release PHP branch seems okay to me and even preferable to picking individual commits, because the latter means that PHP would have a version of the library that doesn't actually exist.

[nielsdos]

Here's the plan: I'll go over this this weekend, merge and sync with Lexbor on master, and then if there are no troubles after some time backport to 8.4