Skip to content

Conversation

madmajestro
Copy link
Contributor

Directives are now correctly filtered out if the line in the php.ini file begins with whitespace characters.

@madmajestro
Copy link
Contributor Author

While analyzing the issue krakjoe/apcu#578 I noticed that the tmp-php.ini file generated by make test can unexpectedly contain extension directives that should have been filtered out, causing all tests to fail.

This happens, if the php.ini file used as basis contains extension directives with leading spaces. In this case, these directives are not filtered out. This will cause all tests to fail if these extensions cannot be loaded during the test run.

@madmajestro madmajestro changed the base branch from PHP-8.0 to PHP-8.3 August 2, 2025 20:50
@madmajestro madmajestro force-pushed the PHP-8.0-fix-deprecated-directive-regex-in-makfile branch from 122a889 to de0f97b Compare August 2, 2025 20:51
@madmajestro
Copy link
Contributor Author

I picked the wrong branch by mistake. Target branch is 8.3 now.

Directives are now correctly filtered out if the line in the php.ini
file begins with whitespace characters.

Closes phpGH-19348
@iluuu1994 iluuu1994 force-pushed the PHP-8.0-fix-deprecated-directive-regex-in-makfile branch from 24ea1d2 to 9d29283 Compare August 4, 2025 14:57
@iluuu1994 iluuu1994 closed this in 9d29283 Aug 4, 2025
@iluuu1994 iluuu1994 merged commit 9d29283 into php:PHP-8.3 Aug 4, 2025
7 of 9 checks passed
@iluuu1994
Copy link
Member

Thank you @madmajestro!

@madmajestro madmajestro deleted the PHP-8.0-fix-deprecated-directive-regex-in-makfile branch August 20, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants