[RFC] Deprecate ReflectionProperty::getDefaultValue() without default #19457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To avoid merge conflicts, NEWS/UPGRADING will be sent once this is approved |
|
The exception if checks just add noise to the code, you return anyway so you might as well drop them. |
TimWolla
requested changes
Aug 12, 2025
DanielEScherzer
force-pushed
the
reflection-missing-default
branch
from
2c9d3ce to
3c1e8e4
Compare
DanielEScherzer
force-pushed
the
reflection-missing-default
branch
from
3c1e8e4 to
7da07bf
Compare
TimWolla
approved these changes
Aug 12, 2025
71 tasks
eliashaeussler
added a commit
to eliashaeussler/Valinor
that referenced
this pull request
Oct 14, 2025
Calling `ReflectionProperty::getDefaultValue()` on a property without a default value is deprecated since PHP v8.5 [1]. The method is now only called if the property actually contains a default value. [1]: php/php-src#19457
romm
pushed a commit
to eliashaeussler/Valinor
that referenced
this pull request
Oct 21, 2025
Calling `ReflectionProperty::getDefaultValue()` on a property without a default value is deprecated since PHP v8.5 [1]. The method is now only called if the property actually contains a default value. [1]: php/php-src#19457
romm
pushed a commit
to CuyZ/Valinor
that referenced
this pull request
Oct 21, 2025
Calling `ReflectionProperty::getDefaultValue()` on a property without a default value is deprecated since PHP v8.5 [1]. The method is now only called if the property actually contains a default value. [1]: php/php-src#19457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/deprecations_php_8_5