-
Notifications
You must be signed in to change notification settings - Fork 8k
Update uriparser to version 0.9.9 #19711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not updating src/UriConfig.h, thus a wrong version number will be reported. Please review #19678 first.
Ah... I had the impression that you are going to remove this file 🤔 But let me have a look at it |
You can now remove it as part of this PR after a rebase for a clean upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified the changes in this PR against a fresh clone of the upstream repository. The C and H files are in sync, but I'm noticing that you did not update the COPYING files.
Both src/ and include/ now have dedicated COPYING files. The one directly in ext/uri/uriparser should be removed and replaced by the COPYING.BSD-3-Clause.
Yes, I noticed it as well, but does it matter? I mean, what is the difference between the two options? P.S. We'll need the UriConfig file |
Ah and CI fails, because the UriConfig.h was actually required by the code itself. |
I consider it important to replicate the upstream repository as close as possible to make updates easier (e.g. just replacing the entire include/ and src/ directories). Also for licensing it would try to very closely follow upstream, so that we do not accidentally get out of sync and claim incorrect information. |
Please also this one: https://github.com/uriparser/uriparser/blob/master/COPYING.BSD-3-Clause for completeness. The other two in the top directory do not matter, since they are for tests and fuzzing code. |
No description provided.