Add offset support to `str_increment`

[mvorisek]

Description

repro: https://3v4l.org/6XDF6#v8.4.12

[iluuu1994]

Can you provide a use case? As this is an API change, it should also be discussed on the mailing list. I think you've been around the block for long enough to know how it goes. 😉

[mvorisek]

Usecase - we use str_increment() for two purposes - for PDO param names and for Excel/G sheet column names. In both cases, we need to calculate next-free name after N columns.

[iluuu1994]

for PDO param names

I don't grasp why this one requires shifting by more than 1.

for Excel/G sheet column names

str_increment() aligns with Excel here more by chance than intention. It's probably the job of the Excel library to offer something here.

The aim of str_increment() was really just to offer a (less wonky) alternative to the deprecated $a++ syntax, which also doesn't offer offsets >1.

This is a valid feature request, and I'll keep it open. But as you also know, it's quite likely that it will be closed in 3 months with no result, so why not be proactive and suggest it on the mailing list?

[mvorisek]

What should I write to the mailing list? I have an idea for improvement?

[iluuu1994]

Yes. It should include a concrete suggestion, ask whether such a change would require an RFC, and if so whether there is interest in it.