Skip to content

Fix GH-20106: locale methods catering to stricter C++ rules. #20110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: PHP-8.5
Choose a base branch
from
Open

Fix GH-20106: locale methods catering to stricter C++ rules. #20110

wants to merge 1 commit into from
+18 −17

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Oct 8, 2025

No description provided.

@devnexen
Copy link
Member Author

devnexen commented Oct 8, 2025

@nono303 would you be able to try this branch ?

@nono303
Copy link
Contributor

nono303 commented Oct 9, 2025

@nono303 would you be able to try this branch ?

Hi @devnexen
applied https://patch-diff.githubusercontent.com/raw/php/php-src/pull/20110.patch and get less errors
see patched.log (and no_patch.log for diff)

@devnexen
Copy link
Member Author

devnexen commented Oct 9, 2025

Can you give another try please ?

@nono303
Copy link
Contributor

nono303 commented Oct 9, 2025 •
edited
Loading

🎉 compile without errors on a9a7858
a9a7858.log

@devnexen devnexen marked this pull request as ready for review October 9, 2025 07:50
@devnexen devnexen linked an issue Oct 9, 2025 that may be closed by this pull request
8.5 MSVC compilation error on ext/intl #20106
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Extension: intl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8.5 MSVC compilation error on ext/intl
2 participants
@devnexen @nono303