Observer API: Function invocation tracking

[th3r0b0t]

Description

Problem

AFAIK one of things Observer API fixes is the old problem with overriding zend_execute_ex forces VM to go into stack execution mode.
Forgive me for I’m a newbie in the field but I see the zend_observer_fcall_handlers’s begin and end handlers as events fired independently; These handlers are given only a zend_execute_data with nothing (AFAICT) to be used as unique identifier.
Memory address of zend_execute_data being reused, hence not suitable either.
I need a way to match the data between begin and end handler for an invocation.

Requested Feature or guidance:

If zend_execute_data could have something like op_array.reserved[] but per-call or any unique property, it would solve the problem.

[bwoebi]

Hey, the zend_execute_data pointer is exactly what we're using.
But the memory is not reused for as long as the call lives. Each begin call will have a matching end call with the same zend_execute_data, and no other call will have that same zend_execute_data in between.
If there's some case where that invariant is violated, that's a problem on the observers.

I agree that it would be nice though, to simply allocate an extra temporary for your extension instead of having to map the execute_data via HashTable, but it's not a requirement, nor a significant overhead, actually.

[th3r0b0t]

@bwoebi
Hi; Yes of course that's how it behaves, no reuse in between, however as you said it too, even tho I can't see any difference overhead-wise, it'll be nicer to just relay on the argument you are passed in instead of having a separate structure. I mean that's kinda unnecessary, be it a HashTable or a stack.

Thank you for considering this.