Fix GH-9420: Attributes on promoted properties (PHP 8.1) #9887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@iluuu1994 You are right but some extension might support PHP 8.1 and provide internal attributes. I think that backporting the fix makes sense in this regard since it clearly fixes an existing bug in a maintained version of PHP. Plus it was basically just copy-paste. 😉 |
|
In that case, let's see what the PHP 8.1 release managers @krakjoe, @ramsey and @patrickallaert think 🙂 |
|
I think this would be good to have in 8.1. @patrickallaert, what do you think? |
|
Given that this wasn't merged into 8.1 which is now security-only, can it be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported #9661 (fixes #9420) to PHP
8.1branch.