Skip to content

Conversation

@nielsdos
Copy link
Member

@nielsdos nielsdos commented Jan 9, 2025

The array merging function may still hold the properties array while the object is already being destroyed. Therefore, we should take into account the refcount in simplexml's destruction code. It may be possible to trigger this in other ways too.

@nielsdos nielsdos linked an issue Jan 9, 2025 that may be closed by this pull request
The array merging function may still hold the properties array while the
object is already being destroyed. Therefore, we should take into
account the refcount in simplexml's destruction code.
It may be possible to trigger this in other ways too.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@nielsdos nielsdos closed this in a2a7287 Jan 9, 2025
charmitro pushed a commit to wasix-org/php that referenced this pull request Mar 13, 2025
The array merging function may still hold the properties array while the
object is already being destroyed. Therefore, we should take into
account the refcount in simplexml's destruction code.
It may be possible to trigger this in other ways too.

Closes phpGH-17421.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion failure Zend/zend_hash.c:1730

2 participants