Fix RCN violations in array functions #18929
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the array functions perform their operation in-place, the `@refcount 1` annotation is wrong and causes a failure under `ZEND_VERIFY_FUNC_INFO`. The test file tests all functions that have the in-place optimization, even those that didn't have the refcount annotation, just to prevent future regressions.
|
Thank you! |
"completely useless func info", alright then This reverts commit ea4807e.
|
Heh now it warns "completely useless func info", so ig let's just drop it altogether... |
|
Merging this as I want to see the effect on the pipeline wrt ICount. I wonder if the ICount change was due to CI/Valgrind noise or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the array functions perform their operation in-place, the
@refcount 1annotation is wrong and causes a failure underZEND_VERIFY_FUNC_INFO.The test file tests all functions that have the in-place optimization, even those that didn't have the refcount annotation, just to prevent future regressions.
@Girgias This should fix the symfony test failures you saw