fastcgi: fcgi_listen(), disallow SO_REUSEADDR socket option on windows. #19365
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To increase security, we trade off performance on failures, see comment for the reasoning behind.
|
@cmb69 I would like to pick up your big brain on this whenever you get the chance :) cheers. |
devnexen
commented
Oct 26, 2025
| * It potentially allow a same address/port combination, even from an active connection (aka port hijacking). | ||
| * We trade the "fast port reuse on failure" ability though but performance ought to take a backseat on this matter. | ||
| * It might be tempting to use SO_EXCLUSIVEADDRINUSE, but it can significantly increase the amount of binding failures | ||
| * without real benefits .. but it is open for discussions. |
There was a problem hiding this comment.
note that even rust forbids its usage on windows as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase security, we trade off performance on failures, see comment for the reasoning behind.