Fix GH-19406: Redeclaring a protected constant in a child class should work #19415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Aug 15, 2025
There was a problem hiding this comment.
I don't think this is the right solution. It allows accessing protected constants on any "cousin" class. E.g.
class P {}
class C1 extends P {
protected const C = 'C1';
}
class C2 extends P {
public static function test() {
var_dump(C1::C);
}
}
C2::test();
// string(2) "C1"The same does not apply to properties. Time complexity is also not great, as zend_check_protected() itself has two loops, giving us O(n²).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19406
The PR only focuses on constants, the other failing cases seem to be fixed already. I targeted 8.4 because of what's been mentioned in the issue.