Cleanup and clarify session.c #19631
Open
+145
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
clean-sess
branch
from
e60aca4 to
41f8787
Compare
Girgias
reviewed
Sep 3, 2025
| @@ -102,6 +102,7 @@ zend_class_entry *php_session_update_timestamp_iface_entry; | |||
|
|
|||
| static zend_result php_session_send_cookie(void); | |||
| static zend_result php_session_abort(void); | |||
| static void ppid2sid(zval *proposed_session_id); | |||
Comment on lines
+1708
to
+1709
| try_find_session_id_in_global("_GET"); | ||
| try_find_session_id_in_global("_POST"); |
There was a problem hiding this comment.
Passing the length into the function by using ZEND_STRL() like before makes the most sense IMO
|
|
||
| if (name && SG(headers_sent)) { | ||
| php_session_headers_already_sent_error(E_WARNING, "Session name cannot be changed after headers have already been sent"); | ||
| if (name && !can_change_session_setting("name", false)) { |
There was a problem hiding this comment.
Probably should have a php_ prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose a little cleanup of this file. It contains very long functions, many duplicates and cryptic names. I think that some util functions, early returns and renaming a few vars help clarify intents and readability.