I love the concept, thanks! Can you show an example failure?

The workflow YML file is generated to make adding/maintaining it easier.

I find it the opposite way: in its current form, I find it very difficult to understand now.

I love the concept, thanks! Can you show an example failure?

Thank you ❤

Using mvorisek@738c667 commit a failure is simulated - see CI results in https://github.com/mvorisek/php-src/actions/runs/19343856007/job/55338921670.

The workflow YML file is generated to make adding/maintaining it easier.

I find it the opposite way: in its current form, I find it very difficult to understand now.

Why, how can it be done better?

Maintaining the yml file by hand would not be practical as names/paths are copied in several places.

Adding a new bundle is easy - add 1 line to https://github.com/php/php-src/blob/94cdb07789/.github/scripts/download-bundled/make-workflow-file.php#L8-L12.

The script also generates partly the download scripts with canonical temporary directory names.

In case you would do any manual change to the yml by mistake, the CI at https://github.com/php/php-src/blob/94cdb07789/.github/actions/verify-generated-files/action.yml#L16 will warn you about.

@TimWolla @iluuu1994 can this PR be merged?

Can this PR be merged please? The MacOS job failure is unrelated. I would like to continue another PR for more sources.

As mentioned, 2/3 of this PR is code that isn't needed. I don't think this should be merged in this state. There are other mechanisms to avoid duplicate code.

Thank you for your message.

I however do not think you can manage
a) the paths when the workflow should run on push
b) the paths for dorny changes detector
c) the unified scripts header

using anything than templating.

The only thing that can be deduplicated using "other mechanisms to avoid duplicate code" is the download/verify step.

Given all a), b), c) (or at least some of them) has no other solution, if we want to avoid mistakes and actual code duplication, the script is needed.

If you know how to avoid it without having to specify the paths/names more than once or twice only, please tell me.

Also please see #20487 and try adding a new definition/line into https://github.com/php/php-src/blob/94cdb07789/.github/scripts/download-bundled/make-workflow-file.php#L8-L12. You will see very quickly the power and benefits the templating script have.