Improve parsing composer.json

shivammathur · shivammathur · commit d172b16269c4 · 2025-08-27T14:08:45.000+05:30
diff --git a/extension/BuildPhpExtension/private/Get-ExtensionConfig.ps1 b/extension/BuildPhpExtension/private/Get-ExtensionConfig.ps1
@@ -97,7 +97,11 @@ Function Get-ExtensionConfig {
             }
             if($null -ne $composerJson -and $null -ne $composerJson."php-ext" -and $null -ne $composerJson."php-ext"."configure-options") {
                 $composerJson."php-ext"."configure-options" | ForEach-Object {
-                    $config.options += "--$( $_.name )"
+                    if($null -ne $_."needs-value" -and $_."needs-value" -eq $true -and $_.name -eq "with-$($Extension.ToLower())") {
+                        $config.options += "--$($_.name)=shared"
+                    } else {
+                        $config.options += "--$( $_.name )"
+                    }
                 }
             }
             $config.options = $config.options -join " "

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,11 @@ Function Get-ExtensionConfig {`
`97`	`97`	`}`
`98`	`98`	`if($null -ne $composerJson -and $null -ne $composerJson."php-ext" -and $null -ne $composerJson."php-ext"."configure-options") {`
`99`	`99`	`$composerJson."php-ext"."configure-options" \| ForEach-Object {`
`100`		`- $config.options += "--$( $_.name )"`
	`100`	`+ if($null -ne $_."needs-value" -and $_."needs-value" -eq $true -and $_.name -eq "with-$($Extension.ToLower())") {`
	`101`	`+ $config.options += "--$($_.name)=shared"`
	`102`	`+ } else {`
	`103`	`+ $config.options += "--$( $_.name )"`
	`104`	`+ }`
`101`	`105`	`}`
`102`	`106`	`}`
`103`	`107`	`$config.options = $config.options -join " "`