Add support for build directory to handle LNK1170 error

Author: shivammathur

.github/workflows/extension.yml

@@ -23,6 +23,9 @@ on:
         description: 'Test runner to use'
         required: false
         default: 'run-tests.php'
+      build-directory:
+        description: 'Directory to build the extension in'
+        required: false
       artifact-naming-scheme:
         description: 'Naming schema for the artifacts, pie or pecl'
         required: false
@@ -68,6 +71,7 @@ jobs:
           ts: ${{ matrix.ts }}
           args: ${{ inputs.args }}
           libs: ${{ inputs.libs }}
+          build-directory: ${{ inputs.build-directory }}
           run-tests: ${{ inputs.run-tests }}
           test-runner: ${{ inputs.test-runner }}
 

README.md

@@ -75,6 +75,7 @@ Build a PHP extension for a specific version.
 - `ts` (required) - The thread safety to build the extension for.
 - `args` (optional) - Additional arguments to pass to the `configure` script.
 - `libs` (optional) - Libraries required for the extension.
+- `build-directory` (optional) - The directory to build the extension in, defaults to the user's temporary directory.
 - `run-tests` (optional) - Run the extension tests. Defaults to `true`.
 - `test-runner` (optional) - The test runner to use. Defaults to `run-tests.php`.
 

extension/BuildPhpExtension/BuildPhpExtension.psd1

@@ -60,7 +60,7 @@
     # NestedModules = @()
 
     # Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
-    FunctionsToExport = 'Invoke-PhpBuildExtension', 'Add-BuildRequirements', 'Add-Path', 'Get-PhpSdk', 'Add-Dependencies', 'Add-PhpDependencies', 'Get-VsVersion', 'Add-Extension', 'Get-Extension', 'Get-ExtensionSource', 'Add-ExtensionDependencies', 'Get-ExtensionConfig', 'Add-Extensions', 'Get-PhpBuild', 'Invoke-Build', 'Invoke-Tests', 'Add-Package', 'Get-PhpDevelBuild', 'Get-OlderVsVersion', 'Get-PeclLibraryZip'
+    FunctionsToExport = 'Invoke-PhpBuildExtension', 'Add-BuildRequirements', 'Add-Path', 'Get-PhpSdk', 'Add-Dependencies', 'Add-PhpDependencies', 'Get-VsVersion', 'Add-Extension', 'Get-Extension', 'Get-BuildDirectory', 'Get-ExtensionSource', 'Add-ExtensionDependencies', 'Get-ExtensionConfig', 'Add-Extensions', 'Get-PhpBuild', 'Invoke-Build', 'Invoke-Tests', 'Add-Package', 'Get-PhpDevelBuild', 'Get-OlderVsVersion', 'Get-PeclLibraryZip'
 
     # Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
     CmdletsToExport = '*'

extension/BuildPhpExtension/private/Get-BuildDirectory.ps1

@@ -0,0 +1,28 @@
+Function Get-BuildDirectory {
+    <#
+    .SYNOPSIS
+        Get the directory to build the extension.
+    #>
+    [OutputType()]
+    param(
+    )
+    begin {
+    }
+    process {
+        if ($null -ne $env:BUILD_DIRECTORY) {
+            $parentBuildDirectory = $env:BUILD_DIRECTORY
+        } else {
+            $parentBuildDirectory = [System.IO.Path]::GetTempPath()
+        }
+
+        $buildDirectory = [System.Guid]::NewGuid().ToString().substring(0, 8)
+
+        $buildDirectoryPath = [System.IO.Path]::Combine($parentBuildDirectory, $buildDirectory)
+
+        New-Item "$buildDirectoryPath" -ItemType "directory" -Force > $null 2>&1
+
+        return $buildDirectoryPath
+    }
+    end {
+    }
+}

extension/BuildPhpExtension/public/Invoke-PhpBuildExtension.ps1

@@ -45,11 +45,7 @@ function Invoke-PhpBuildExtension {
 
         $currentDirectory = (Get-Location).Path
 
-        $tempDirectory = [System.IO.Path]::GetTempPath()
-
-        $buildDirectory = [System.IO.Path]::Combine($tempDirectory, [System.Guid]::NewGuid().ToString())
-
-        New-Item "$buildDirectory" -ItemType "directory" -Force > $null 2>&1
+        $buildDirectory = Get-BuildDirectory
 
         Set-Location "$buildDirectory"
 

extension/action.yml

@@ -36,6 +36,10 @@ inputs:
     description: Test runner to use
     required: false
     default: 'run-tests.php'
+  build-directory:
+    description: Directory to build the extension in
+    required: false
+    default: 'build'
   artifact-naming-scheme:
     description: Naming schema for the artifacts, pie or pecl
     deprecationMessage: "This will be removed once pie is released"
@@ -56,6 +60,7 @@ runs:
         ARTIFACT_NAMING_SCHEME: ${{inputs.artifact-naming-scheme}}
         RUN_TESTS: ${{inputs.run-tests}}
         TEST_RUNNER: ${{inputs.test-runner}}
+        BUILD_DIRECTORY: ${{inputs.build-directory}}
       run: |
         Import-Module ${{ github.action_path }}\BuildPhpExtension -Force
         Invoke-PhpBuildExtension -ExtensionUrl "${{inputs.extension-url}}" `