Fix packaging to not include pdf files without DLLs

shivammathur · shivammathur · commit fb5fcd7f2b03 · 2024-10-12T04:01:59.000+05:30
diff --git a/extension/BuildPhpExtension/private/Add-Package.ps1 b/extension/BuildPhpExtension/private/Add-Package.ps1
@@ -51,9 +51,10 @@ function Add-Package {
             # TODO: Filter these using deplister
             if(Test-Path ..\deps\bin) {
                 Get-ChildItem -Path ..\deps\bin -Recurse -Include "*.dll", "*.pdb" | ForEach-Object {
-                    $fileName = $_.Name.Split('.')[0]
-                    if(-not(Test-Path "php-bin\$fileName.dll")) {
-                        Copy-Item -Path $_.FullName -Destination artifacts -Force
+                    if(-not(Test-Path "php-bin\$($_.Name.Split('.')[0]).dll")) {
+                        if($_.Extension -eq ".dll" -or (Test-Path ([IO.Path]::ChangeExtension($_.FullName, "dll")))) {
+                            Copy-Item -Path $_.FullName -Destination artifacts -Force
+                        }
                     }
                 }
                 if(Test-Path (Join-Path -Path ..\deps\bin -ChildPath "*.xml")) {

Original file line number	Diff line number	Diff line change
`@@ -51,9 +51,10 @@ function Add-Package {`
`51`	`51`	`# TODO: Filter these using deplister`
`52`	`52`	`if(Test-Path ..\deps\bin) {`
`53`	`53`	`Get-ChildItem -Path ..\deps\bin -Recurse -Include ".dll", ".pdb" \| ForEach-Object {`
`54`		`- $fileName = $_.Name.Split('.')[0]`
`55`		`- if(-not(Test-Path "php-bin\$fileName.dll")) {`
`56`		`- Copy-Item -Path $_.FullName -Destination artifacts -Force`
	`54`	`+ if(-not(Test-Path "php-bin\$($_.Name.Split('.')[0]).dll")) {`
	`55`	`+ if($_.Extension -eq ".dll" -or (Test-Path ([IO.Path]::ChangeExtension($_.FullName, "dll")))) {`
	`56`	`+ Copy-Item -Path $_.FullName -Destination artifacts -Force`
	`57`	`+ }`
`57`	`58`	`}`
`58`	`59`	`}`
`59`	`60`	`if(Test-Path (Join-Path -Path ..\deps\bin -ChildPath "*.xml")) {`