Skip to content

Commit 3961d1b

Browse files
authored
Merge pull request #314 from asgrim/clarify-win-arch-docs
Clarify normalisation of Windows architecture values
2 parents 102a8bd + 805d487 commit 3961d1b

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

docs/extension-maintainers.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,9 +331,20 @@ The descriptions of these items:
331331
'PHP Extension Build' flags in `php -i`
332332
* `ts|nts` - Thread-safe or non-thread safe.
333333
* `arch` - for example `x86_64`.
334-
* Windows: `Architecture` from `php -i`
334+
* Windows: use a hint from `Architecture` from `php -i` (see below)
335335
* non-Windows: check `PHP_INT_SIZE` - 4 for 32-bit, 8 for 64-bit.
336336

337+
Note the architecture name will likely need normalising, since different
338+
platforms name architectures differently. PIE expects the following normalised
339+
architectures:
340+
341+
* `x86_64` (normalised from `x64`, `x86_64`, `AMD64`)
342+
* `arm64` (normalised from `arm64`)
343+
* `x86` (any other value)
344+
345+
For the latest map (in case documentation is not up to date), check out
346+
`\Php\Pie\Platform\Architecture::parseArchitecture`.
347+
337348
#### Contents of the Windows ZIP
338349

339350
The pre-built ZIP should contain at minimum a DLL named in the same way as the

0 commit comments

Comments
 (0)