Update errors to use writeError

asgrim · asgrim · commit f24fa3a23162 · 2025-10-16T19:44:22.000+01:00
diff --git a/src/Command/BuildCommand.php b/src/Command/BuildCommand.php
@@ -92,8 +92,8 @@ public function execute(InputInterface $input, OutputInterface $output): int
                 $this->container,
             );
         } catch (BundledPhpExtensionRefusal $bundledPhpExtensionRefusal) {
-            $this->io->write('');
-            $this->io->write('<comment>' . $bundledPhpExtensionRefusal->getMessage() . '</comment>');
+            $this->io->writeError('');
+            $this->io->writeError('<comment>' . $bundledPhpExtensionRefusal->getMessage() . '</comment>');
 
             return self::INVALID;
         }
@@ -128,7 +128,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
                 false,
             );
         } catch (ComposerRunFailed $composerRunFailed) {
-            $this->io->write('<error>' . $composerRunFailed->getMessage() . '</error>');
+            $this->io->writeError('<error>' . $composerRunFailed->getMessage() . '</error>');
 
             return $composerRunFailed->getCode();
         }
diff --git a/src/Command/CommandHelper.php b/src/Command/CommandHelper.php
@@ -365,9 +365,9 @@ public static function handlePackageNotFound(
             $requestedPackageName = substr($requestedPackageName, 4);
         }
 
-        $io->write('');
-        $io->write(sprintf('<error>Could not install package: %s</error>', $requestedPackageName));
-        $io->write($exception->getMessage());
+        $io->writeError('');
+        $io->writeError(sprintf('<error>Could not install package: %s</error>', $requestedPackageName));
+        $io->writeError($exception->getMessage());
 
         try {
             $matches = array_map(
@@ -382,7 +382,7 @@ static function (array $match) use ($io, $pieComposer): array {
                                 ->extensionName()
                                 ->name();
                         } catch (Throwable $t) {
-                            $io->write(
+                            $io->writeError(
                                 sprintf(
                                     'Tried looking up extension name for %s, but failed: %s',
                                     $match['name'],
@@ -421,7 +421,7 @@ static function (array $match) use ($io): void {
                 );
             }
         } catch (OutOfRangeException) {
-            $io->write(
+            $io->writeError(
                 sprintf(
                     'Tried searching for "%s", but nothing was found.',
                     $requestedPackageName,
diff --git a/src/Command/DownloadCommand.php b/src/Command/DownloadCommand.php
@@ -94,8 +94,8 @@ public function execute(InputInterface $input, OutputInterface $output): int
                 $this->container,
             );
         } catch (BundledPhpExtensionRefusal $bundledPhpExtensionRefusal) {
-            $this->io->write('');
-            $this->io->write('<comment>' . $bundledPhpExtensionRefusal->getMessage() . '</comment>');
+            $this->io->writeError('');
+            $this->io->writeError('<comment>' . $bundledPhpExtensionRefusal->getMessage() . '</comment>');
 
             return self::INVALID;
         }
@@ -112,7 +112,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
                 false,
             );
         } catch (ComposerRunFailed $composerRunFailed) {
-            $this->io->write('<error>' . $composerRunFailed->getMessage() . '</error>');
+            $this->io->writeError('<error>' . $composerRunFailed->getMessage() . '</error>');
 
             return $composerRunFailed->getCode();
         }
diff --git a/src/Command/InfoCommand.php b/src/Command/InfoCommand.php
@@ -98,8 +98,8 @@ public function execute(InputInterface $input, OutputInterface $output): int
                 $this->container,
             );
         } catch (BundledPhpExtensionRefusal $bundledPhpExtensionRefusal) {
-            $this->io->write('');
-            $this->io->write('<comment>' . $bundledPhpExtensionRefusal->getMessage() . '</comment>');
+            $this->io->writeError('');
+            $this->io->writeError('<comment>' . $bundledPhpExtensionRefusal->getMessage() . '</comment>');
 
             return self::INVALID;
         }
diff --git a/src/Command/InstallCommand.php b/src/Command/InstallCommand.php
@@ -106,8 +106,8 @@ public function execute(InputInterface $input, OutputInterface $output): int
                 $this->container,
             );
         } catch (BundledPhpExtensionRefusal $bundledPhpExtensionRefusal) {
-            $this->io->write('');
-            $this->io->write('<comment>' . $bundledPhpExtensionRefusal->getMessage() . '</comment>');
+            $this->io->writeError('');
+            $this->io->writeError('<comment>' . $bundledPhpExtensionRefusal->getMessage() . '</comment>');
 
             return self::INVALID;
         }
@@ -142,7 +142,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
                 true,
             );
         } catch (ComposerRunFailed $composerRunFailed) {
-            $this->io->write('<error>' . $composerRunFailed->getMessage() . '</error>');
+            $this->io->writeError('<error>' . $composerRunFailed->getMessage() . '</error>');
 
             return $composerRunFailed->getCode();
         }
diff --git a/src/Command/InstallExtensionsForProjectCommand.php b/src/Command/InstallExtensionsForProjectCommand.php
@@ -101,7 +101,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
         if (ExtensionType::isValid($rootPackage->getType())) {
             $cwd = realpath(getcwd());
             if (! is_string($cwd) || $cwd === '') {
-                $this->io->write('<error>Failed to determine current working directory.</error>');
+                $this->io->writeError('<error>Failed to determine current working directory.</error>');
 
                 $restoreWorkingDir();
 
@@ -124,7 +124,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
 
         $allowNonInteractive = $input->hasOption(CommandHelper::OPTION_ALLOW_NON_INTERACTIVE_PROJECT_INSTALL) && $input->getOption(CommandHelper::OPTION_ALLOW_NON_INTERACTIVE_PROJECT_INSTALL);
         if (! Platform::isInteractive() && ! $allowNonInteractive) {
-            $this->io->write(sprintf(
+            $this->io->writeError(sprintf(
                 '<warning>Aborting! You are not running in interactive mode, and --%s was not specified.</warning>',
                 CommandHelper::OPTION_ALLOW_NON_INTERACTIVE_PROJECT_INSTALL,
             ));
@@ -226,7 +226,7 @@ function (Link $link) use ($pieComposer, $phpEnabledExtensions, $installedPiePac
                     $anyErrorsHappened = true;
 
                     // @todo Figure out if there is a way to improve this, safely
-                    $this->io->write(sprintf(
+                    $this->io->writeError(sprintf(
                         "<warning>Multiple packages were found for %s:</warning>\n  %s\n\n<warning>This means you cannot `pie install` this project interactively for now.</warning>",
                         $extension->nameWithExtPrefix(),
                         implode("\n  ", array_column($matches, 'name')),
diff --git a/src/Command/SelfUpdateCommand.php b/src/Command/SelfUpdateCommand.php
@@ -84,7 +84,7 @@ public function configure(): void
     public function execute(InputInterface $input, OutputInterface $output): int
     {
         if (! PieVersion::isPharBuild()) {
-            $this->io->write('<comment>Aborting! You are not running a PHAR, cannot self-update.</comment>');
+            $this->io->writeError('<comment>Aborting! You are not running a PHAR, cannot self-update.</comment>');
 
             return Command::FAILURE;
         }
@@ -131,7 +131,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
             try {
                 $latestRelease = $fetchLatestPieRelease->latestReleaseMetadata($updateChannel);
             } catch (Throwable $throwable) {
-                $this->io->write(sprintf('<error>%s</error>', $throwable->getMessage()));
+                $this->io->writeError(sprintf('<error>%s</error>', $throwable->getMessage()));
 
                 return Command::FAILURE;
             }
@@ -165,13 +165,13 @@ public function execute(InputInterface $input, OutputInterface $output): int
         try {
             $verifyPiePhar->verify($latestRelease, $pharFilename, $this->io);
         } catch (FailedToVerifyRelease $failedToVerifyRelease) {
-            $this->io->write(sprintf(
+            $this->io->writeError(sprintf(
                 '<error>❌ Failed to verify the pie.phar release %s: %s</error>',
                 $latestRelease->tag,
                 $failedToVerifyRelease->getMessage(),
             ));
 
-            $this->io->write('This means I could not verify that the PHAR we tried to update to was authentic, so I am aborting the self-update.');
+            $this->io->writeError('This means I could not verify that the PHAR we tried to update to was authentic, so I am aborting the self-update.');
             unlink($pharFilename->filePath);
 
             return Command::FAILURE;
diff --git a/src/Command/SelfVerifyCommand.php b/src/Command/SelfVerifyCommand.php
@@ -42,7 +42,7 @@ public function configure(): void
     public function execute(InputInterface $input, OutputInterface $output): int
     {
         if (! PieVersion::isPharBuild()) {
-            $this->io->write('<comment>Aborting! You are not running a PHAR, cannot self-verify.</comment>');
+            $this->io->writeError('<comment>Aborting! You are not running a PHAR, cannot self-verify.</comment>');
 
             return Command::FAILURE;
         }
@@ -54,7 +54,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
         try {
             $verifyPiePhar->verify($latestRelease, $pharFilename, $this->io);
         } catch (FailedToVerifyRelease $failedToVerifyRelease) {
-            $this->io->write(sprintf(
+            $this->io->writeError(sprintf(
                 '<error>❌ Failed to verify the pie.phar release %s: %s</error>',
                 $latestRelease->tag,
                 $failedToVerifyRelease->getMessage(),
diff --git a/src/Command/UninstallCommand.php b/src/Command/UninstallCommand.php
@@ -76,7 +76,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
         $piePackage = $this->findPiePackageByPackageName($packageToRemove, $composer);
 
         if ($piePackage === null) {
-            $this->io->write('<error>No package found: ' . $packageToRemove . '</error>');
+            $this->io->writeError('<error>No package found: ' . $packageToRemove . '</error>');
 
             return 1;
         }
diff --git a/src/ComposerIntegration/Listeners/RemoveUnrelatedInstallOperations.php b/src/ComposerIntegration/Listeners/RemoveUnrelatedInstallOperations.php
@@ -47,7 +47,7 @@ public function __invoke(InstallerEvent $installerEvent): void
             $installerEvent->getTransaction()?->getOperations() ?? [],
             function (OperationInterface $operation) use ($pieOutput): bool {
                 if (! $operation instanceof InstallOperation && ! $operation instanceof UninstallOperation) {
-                    $pieOutput->write(
+                    $pieOutput->writeError(
                         sprintf(
                             'Unexpected operation during installer: %s',
                             $operation::class,
@@ -61,7 +61,7 @@ function (OperationInterface $operation) use ($pieOutput): bool {
                 $isRequestedPiePackage = $this->composerRequest->requestedPackage->package === $operation->getPackage()->getName();
 
                 if (! $isRequestedPiePackage) {
-                    $pieOutput->write(
+                    $pieOutput->writeError(
                         sprintf(
                             'Filtering package %s from install operations, as it was not the requested package',
                             $operation->getPackage()->getName(),
diff --git a/src/ComposerIntegration/PiePackageInstaller.php b/src/ComposerIntegration/PiePackageInstaller.php
@@ -53,7 +53,7 @@ public function install(InstalledRepositoryInterface $repo, PackageInterface $pa
                 }
 
                 if (! $composerPackage instanceof CompletePackage) {
-                    $io->write(sprintf(
+                    $io->writeError(sprintf(
                         '<error>Not using PIE to install %s as it was not a Complete Package</error>',
                         $composerPackage->getName(),
                     ));
@@ -95,7 +95,7 @@ public function uninstall(InstalledRepositoryInterface $repo, PackageInterface $
                 }
 
                 if (! $composerPackage instanceof CompletePackage) {
-                    $io->write(sprintf(
+                    $io->writeError(sprintf(
                         '<error>Not using PIE to install %s as it was not a Complete Package</error>',
                         $composerPackage->getName(),
                     ));
diff --git a/src/Installing/Ini/AddExtensionToTheIniFile.php b/src/Installing/Ini/AddExtensionToTheIniFile.php
@@ -93,7 +93,7 @@ public function __invoke(
         } catch (Throwable $anything) {
             SudoFilePut::contents($ini, $originalIniContent);
 
-            $io->write(sprintf(
+            $io->writeError(sprintf(
                 '<error>Something went wrong enabling the %s extension: %s</error>',
                 $package->extensionName()->name(),
                 $anything->getMessage(),
diff --git a/src/Installing/Ini/CheckAndAddExtensionToIniIfNeeded.php b/src/Installing/Ini/CheckAndAddExtensionToIniIfNeeded.php
@@ -63,7 +63,7 @@ public function __invoke(
 
                 return true;
             } catch (Throwable $anything) {
-                $io->write(sprintf(
+                $io->writeError(sprintf(
                     '<error>Something went wrong verifying the %s extension is enabled: %s</error>',
                     $downloadedPackage->package->extensionName()->name(),
                     $anything->getMessage(),
diff --git a/src/Installing/Ini/DockerPhpExtEnable.php b/src/Installing/Ini/DockerPhpExtEnable.php
@@ -43,7 +43,7 @@ public function setup(
         try {
             $enableOutput = Process::run([$dockerPhpExtEnable, $downloadedPackage->package->extensionName()->name()]);
         } catch (ProcessFailedException $processFailed) {
-            $io->write(
+            $io->writeError(
                 sprintf(
                     'Could not enable extension %s using %s. Exception was: %s',
                     $downloadedPackage->package->extensionName()->name(),
@@ -64,7 +64,7 @@ public function setup(
 
             return true;
         } catch (ExtensionIsNotLoaded) {
-            $io->write(
+            $io->writeError(
                 sprintf(
                     'Asserting that extension %s was enabled using %s failed. Output was: %s',
                     $downloadedPackage->package->extensionName()->name(),
diff --git a/src/Installing/Ini/OndrejPhpenmod.php b/src/Installing/Ini/OndrejPhpenmod.php
@@ -170,7 +170,7 @@ static function () use ($needSudo, $phpenmodPath, $targetPlatform, $downloadedPa
 
                     return true;
                 } catch (ProcessFailedException $processFailedException) {
-                    $io->write(
+                    $io->writeError(
                         sprintf(
                             'Failed to use %s to enable %s for PHP %s: %s',
                             $phpenmodPath,
diff --git a/src/Installing/Ini/RemoveIniEntryWithFileGetContents.php b/src/Installing/Ini/RemoveIniEntryWithFileGetContents.php
@@ -96,7 +96,7 @@ static function (string $iniFile) use (&$updatedIniFiles, $regex, $package, $io)
                 try {
                     SudoFilePut::contents($iniFile, $replacedContent);
                 } catch (FailedToWriteFile) {
-                    $io->write(sprintf(
+                    $io->writeError(sprintf(
                         '<error>Failed to remove extension "%s" from INI file "%s"</error>',
                         $package->extensionName()->name(),
                         $iniFile,
diff --git a/src/SelfManage/Verify/VerifyPieReleaseUsingAttestation.php b/src/SelfManage/Verify/VerifyPieReleaseUsingAttestation.php
@@ -34,7 +34,7 @@ public function verify(ReleaseMetadata $releaseMetadata, BinaryFile $pharFilenam
         try {
             $this->githubCliVerification->verify($releaseMetadata, $pharFilename, $io);
         } catch (GithubCliNotAvailable $githubCliNotAvailable) {
-            $io->write($githubCliNotAvailable->getMessage(), verbosity: IOInterface::VERBOSE);
+            $io->writeError($githubCliNotAvailable->getMessage(), verbosity: IOInterface::VERBOSE);
 
             if (! extension_loaded('openssl')) {
                 throw FailedToVerifyRelease::fromNoOpenssl();

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function execute(InputInterface $input, OutputInterface $output): int`
`76`	`76`	`$piePackage = $this->findPiePackageByPackageName($packageToRemove, $composer);`
`77`	`77`
`78`	`78`	`if ($piePackage === null) {`
`79`		`- $this->io->write('<error>No package found: ' . $packageToRemove . '</error>');`
	`79`	`+ $this->io->writeError('<error>No package found: ' . $packageToRemove . '</error>');`
`80`	`80`
`81`	`81`	`return 1;`
`82`	`82`	`}`