Skip to content

Commit 039b87e

Browse files
committed
Apply PR feedback to remove 'prior version' logic
1 parent b758b4d commit 039b87e

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

downloads-get-instructions.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
<?php
22
$file = 'unknown';
33
$latestPhpVersion = '8.4';
4-
$priorPhpVersion = '8.3';
54

65
if (!isset($options)) {
76
$options = [
87
'os' => '',
98
'usage' => '',
109
'version' => '',
11-
'priorVersion' => $priorPhpVersion,
1210
];
1311
}
1412

@@ -67,8 +65,6 @@
6765

6866
$version = $options['version'];
6967
$versionNoDot = str_replace('.', '', $version);
70-
$priorVersion = $options['priorVersion'];
71-
$priorVersionNoDot = str_replace('.', '', $priorPhpVersion);
7268

7369
if (file_exists(__DIR__ . "/include/download-instructions/{$file}.php")) {
7470
include __DIR__ . "/include/download-instructions/{$file}.php";

include/download-instructions/osx-macports.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33
</p>
44
<pre><code class="language-bash line-numbers">
55
# Please refer to https://guide.macports.org/chunked/installing.macports.html for installing MacPorts.
6-
sudo port install php<?= $versionNoDot; ?>
76

8-
# To install a previous version:
9-
sudo port install php<?= $priorVersionNoDot; ?>
7+
# Install PHP <?= $version; ?>
8+
sudo port install php<?= $versionNoDot; ?>
109

11-
# To switch to a different version:
12-
sudo port select php php<?= $priorVersionNoDot; ?>
10+
# Switch Active PHP <?= $version; ?> version
11+
sudo port select php php<?= $versionNoDot; ?>
1312
</code></pre>

0 commit comments

Comments
 (0)