Skip to content

Commit 29f24d0

Browse files
authored
Fix GH-676: Releases RSS/ATOM feed does not validate
The feed's updated element is required before the entries. Closes GH-678.
1 parent c46c30f commit 29f24d0

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

releases/feed.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
1919
XML;
2020

21+
ob_start();
22+
2123
// Flatten major versions out of RELEASES.
2224
$RELEASED_VERSIONS = array_reduce($RELEASES, 'array_merge', []);
2325
$FEED_UPDATED = 0;
@@ -80,9 +82,10 @@
8082
$FEED_UPDATED = max($maxtime, $FEED_UPDATED);
8183
}
8284

85+
$entries = ob_get_clean();
86+
8387
$FEED_UPDATED = date(DATE_ATOM, max($FEED_UPDATED));
8488

85-
echo <<<XML
86-
<updated>{$FEED_UPDATED}</updated>
87-
</feed>
88-
XML;
89+
echo " <updated>{$FEED_UPDATED}</updated>\n";
90+
echo $entries;
91+
echo "</feed>";

0 commit comments

Comments
 (0)