phpstan improvements

Author: jaapio

phive.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phive xmlns="https://phar.io/phive">
-  <phar name="phpstan" version="^0.9.1" installed="0.10.2" location="./tools/phpstan" copy="true"/>
-  <phar name="phpunit" version="^6.0" installed="6.5.5" location="./tools/phpunit" copy="true"/>
+  <phar name="phpstan" version="^0.9.1" installed="0.10.7" location="./tools/phpstan" copy="true"/>
+  <phar name="phpunit" version="^6.0" installed="6.5.13" location="./tools/phpunit" copy="true"/>
 </phive>

phpstan.neon

@@ -1,5 +1,7 @@
 parameters:
     ignoreErrors:
+
+        - '#Method phpDocumentor\\Reflection\\File\\LocalFile::\md5\(\) should return string but returns string\|false\.#'
         #
         # all these $fqsen errors indicate the need for a decorator class around PhpParser\Node to hold the public $fqsen that Reflection is giving it)
         #

tests/unit/phpDocumentor/Reflection/File/LocalFileTest.php

@@ -38,6 +38,15 @@ public function testMd5()
         $this->assertEquals(md5_file(__FILE__), $file->md5());
     }
 
+    /**
+     * @covers ::__construct
+     * @expectedException \InvalidArgumentException
+     */
+    public function testNotExistingFileThrowsException()
+    {
+        new LocalFile('aa');
+    }
+
     /**
      * @covers ::path
      */

tests/unit/phpDocumentor/Reflection/Php/ArgumentTest.php

@@ -27,10 +27,16 @@ class ArgumentTest extends TestCase
      */
     public function testGetTypes()
     {
-        $argument = new Argument('myArgument', null,'myDefaultValue', true, true);
+        $argument = new Argument('myArgument', null, 'myDefaultValue', true, true);
         $this->assertInstanceOf(Mixed_::class, $argument->getType());
 
-        $argument = new Argument('myArgument', new String_(),'myDefaultValue', true, true);
+        $argument = new Argument(
+            'myArgument',
+            new String_(),
+            'myDefaultValue',
+            true,
+            true
+        );
         $this->assertEquals(new String_(), $argument->getType());
     }
 
@@ -50,7 +56,7 @@ public function testGetName()
      */
     public function testGetDefault()
     {
-        $argument = new Argument('myArgument', null,'myDefaultValue', true, true);
+        $argument = new Argument('myArgument', null, 'myDefaultValue', true, true);
         $this->assertEquals('myDefaultValue', $argument->getDefault());
 
         $argument = new Argument('myArgument', null, null, true, true);
@@ -63,7 +69,7 @@ public function testGetDefault()
      */
     public function testGetWhetherArgumentIsPassedByReference()
     {
-        $argument = new Argument('myArgument', null,'myDefaultValue', true, true);
+        $argument = new Argument('myArgument', null, 'myDefaultValue', true, true);
         $this->assertTrue($argument->isByReference());
 
         $argument = new Argument('myArgument', null, null, false, true);
@@ -76,7 +82,7 @@ public function testGetWhetherArgumentIsPassedByReference()
      */
     public function testGetWhetherArgumentisVariadic()
     {
-        $argument = new Argument('myArgument', null,'myDefaultValue', true, true);
+        $argument = new Argument('myArgument', null, 'myDefaultValue', true, true);
         $this->assertTrue($argument->isVariadic());
 
         $argument = new Argument('myArgument', null, 'myDefaultValue', true, false);